Skip to content

Fix broken WASIp1 reference link #151639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 1 commit into from
Jan 26, 2026
Merged

Fix broken WASIp1 reference link #151639

rust-bors merged 1 commit into from
Jan 26, 2026
+1 −1

Conversation

@zzaekkii
Copy link
Contributor

@zzaekkii zzaekkii commented Jan 25, 2026

Location (URL)

https://doc.rust-lang.org/rustc/platform-support/wasm32-wasip1.html

image

Summary

The WASIp1 reference link in the wasm32-wasip1 platform documentation currently points to a path that no longer exists in the WASI repository.

The WASI project recently migrated the WASI 0.1 (preview1) documentation from the legacy/preview1 directory to the dedicated wasi-0.1 branch (WebAssembly/WASI#855).

This updates the link to point to the intended historical WASIp1 reference, which matches the documented intent of the wasm32-wasip1 target.

@rustbot
Copy link
Collaborator

rustbot commented Jan 25, 2026

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 25, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 25, 2026

r? @madsmtm

rustbot has assigned @madsmtm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@zzaekkii zzaekkii closed this Jan 25, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 25, 2026
@zzaekkii zzaekkii reopened this Jan 25, 2026
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 25, 2026
@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Jan 25, 2026

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
REPOSITORY                                   TAG       IMAGE ID       CREATED      SIZE
ghcr.io/dependabot/dependabot-updater-core   latest    354d02aa29ac   5 days ago   783MB
=> Removing docker images...
Deleted Images:
untagged: ghcr.io/dependabot/dependabot-updater-core:latest
untagged: ghcr.io/dependabot/dependabot-updater-core@sha256:596da3f22bcbdff2c96fd7126001278022c834c1621c5efa2ad1a7794590636c
deleted: sha256:354d02aa29acf525570c732b6e006ecf138de6d63ca525d552eb4b24880ddc6c
deleted: sha256:8b7af0e426bc2cbeeacfd96b8354d3b80016991520977197e62090e47abaede8
deleted: sha256:cadf11ef1de7fdd5eab563757942353684047f09b212dc99d6ed48e8acf34d62
deleted: sha256:569b0caf9d5285db44ccd2629a3470139eea755be423a33a54d8a24cb3926bfa
deleted: sha256:f9dc5feb048d8f9fd43137e3998f59e9acfbd76c47a4e14984d109654119e282
---
tests/ui/drain_collect.fixed ... ok
tests/ui/double_parens.rs ... ok
tests/ui/duplicate_underscore_argument.rs ... ok
tests/ui/duplicated_attributes.rs ... ok
tests/ui/duration_suboptimal_units.rs ... ok
tests/ui/duration_suboptimal_units_days_weeks.rs ... ok
tests/ui/duration_subsec.rs ... ok
tests/ui/double_parens.fixed ... ok
tests/ui/duration_suboptimal_units_days_weeks.fixed ... ok
tests/ui/duration_suboptimal_units.fixed ... ok
tests/ui/duration_subsec.fixed ... ok
tests/ui/else_if_without_else.rs ... ok
tests/ui/empty_docs.rs ... ok
tests/ui/eager_transmute.rs ... ok
tests/ui/elidable_lifetime_names.rs ... ok
---
...............................................    (147/147)

======== tests/rustdoc-gui/globals.goml ========

[ERROR] line 14: The following errors happened: [Property named `"searchIndex"` doesn't exist]: for command `assert-window-property-false: {"searchIndex": null}`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/index.html?search=Foo>

======== tests/rustdoc-gui/search-result-display.goml ========

[WARNING] line 39: Delta is 0 for "x", maybe try to use `compare-elements-position` instead?

@madsmtm madsmtm mentioned this pull request Jan 25, 2026
Open
@madsmtm
Copy link
Contributor

madsmtm commented Jan 25, 2026 •
edited
Loading

@bors retry

(Failure was spurious)

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 25, 2026

❗ You can only retry pull requests that are approved and have a previously failed auto build.

@madsmtm
Copy link
Contributor

madsmtm commented Jan 25, 2026

Nvmd, I had to press buttons in GHs UI instead.

Anyway, thanks for the fix.
@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 25, 2026

📌 Commit 9e80b1b has been approved by madsmtm

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 25, 2026
@madsmtm madsmtm added A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools O-wasm Target: WASM (WebAssembly), http://webassembly.org/ labels Jan 25, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Jan 26, 2026
@jhpratt
Rollup merge of rust-lang#151639 - zzaekkii:wasm32-wasip1, r=madsmtm
efe56a5 
Fix broken WASIp1 reference link

### Location (URL)
https://doc.rust-lang.org/rustc/platform-support/wasm32-wasip1.html

<img width="800" alt="image" src="https://github.com/user-attachments/assets/b9402b3a-db7b-405f-b4ef-d849c03ad893" />

### Summary
The WASIp1 reference link in the `wasm32-wasip1` platform documentation currently points to a path that no longer exists in the WASI repository.

The WASI project recently migrated the WASI 0.1 (preview1) documentation from the `legacy/preview1` directory to the dedicated `wasi-0.1` branch (WebAssembly/WASI#855).

This updates the link to point to the intended historical WASIp1 reference, which matches the documented intent of the `wasm32-wasip1` target.
@jhpratt jhpratt mentioned this pull request Jan 26, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Jan 26, 2026
@bors
Auto merge of #151664 - jhpratt:rollup-scDdbzg, r=jhpratt
b614256 
Rollup of 4 pull requests

Successful merges:

 - #150353 (refactor rustc-hash integration)
 - #151611 (Improve is_ascii performance on x86_64 with explicit SSE2 intrinsics)
 - #150705 (Add missing mut to pin.rs docs)
 - #151639 (Fix broken WASIp1 reference link)
@Zalathar Zalathar mentioned this pull request Jan 26, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Jan 26, 2026
@bors
Auto merge of #151667 - Zalathar:rollup-OzG0S5m, r=Zalathar
0462e8f 
Rollup of 6 pull requests

Successful merges:

 - #151611 (Improve is_ascii performance on x86_64 with explicit SSE2 intrinsics)
 - #150705 (Add missing mut to pin.rs docs)
 - #151294 (compiletest: add implied `needs-target-std` for `codegen` mode tests unless annotated with `#![no_std]`/`#![no_core]`)
 - #151589 (Add a `documentation` remapping path scope for rustdoc usage)
 - #151639 (Fix broken WASIp1 reference link)
 - #151645 (Update `sysinfo` version to `0.38.0`)
@rust-bors rust-bors bot merged commit 237d17f into rust-lang:main Jan 26, 2026
19 of 36 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 26, 2026
rust-timer added a commit that referenced this pull request Jan 26, 2026
@rust-timer
Unrolled build for #151639
d971337 
Rollup merge of #151639 - zzaekkii:wasm32-wasip1, r=madsmtm

Fix broken WASIp1 reference link

### Location (URL)
https://doc.rust-lang.org/rustc/platform-support/wasm32-wasip1.html

<img width="800" alt="image" src="https://github.com/user-attachments/assets/b9402b3a-db7b-405f-b4ef-d849c03ad893" />

### Summary
The WASIp1 reference link in the `wasm32-wasip1` platform documentation currently points to a path that no longer exists in the WASI repository.

The WASI project recently migrated the WASI 0.1 (preview1) documentation from the `legacy/preview1` directory to the dedicated `wasi-0.1` branch (WebAssembly/WASI#855).

This updates the link to point to the intended historical WASIp1 reference, which matches the documented intent of the `wasm32-wasip1` target.
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jan 26, 2026
@bors
Auto merge of #151667 - Zalathar:rollup-OzG0S5m, r=Zalathar
a136707 
Rollup of 6 pull requests

Successful merges:

 - rust-lang/rust#151611 (Improve is_ascii performance on x86_64 with explicit SSE2 intrinsics)
 - rust-lang/rust#150705 (Add missing mut to pin.rs docs)
 - rust-lang/rust#151294 (compiletest: add implied `needs-target-std` for `codegen` mode tests unless annotated with `#![no_std]`/`#![no_core]`)
 - rust-lang/rust#151589 (Add a `documentation` remapping path scope for rustdoc usage)
 - rust-lang/rust#151639 (Fix broken WASIp1 reference link)
 - rust-lang/rust#151645 (Update `sysinfo` version to `0.38.0`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@madsmtm madsmtm

Labels

A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools O-wasm Target: WASM (WebAssembly), http://webassembly.org/ S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

4 participants

@zzaekkii @rustbot @rust-log-analyzer @madsmtm